mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 36816: Supported HTTP/HTTPS in health check.
Date Tue, 16 Aug 2016 23:59:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/#review145934
-----------------------------------------------------------




src/health-check/health_checker.cpp (lines 362 - 363)
<https://reviews.apache.org/r/36816/#comment212284>

    Instead of `setns` here, how about creating a subprocess hook and do it there? This way
we guarantee there is a single thread (libprocess has not been initialized yet) and that the
network namespace is set before `curl` invocation.


- Alexander Rukletsov


On Aug. 15, 2016, 3:42 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36816/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2016, 3:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón Kleiman, Gilbert
Song, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2533
>     https://issues.apache.org/jira/browse/MESOS-2533
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported HTTP/HTTPS in health check.
> 
> 
> Diffs
> -----
> 
>   src/health-check/health_checker.hpp b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 
>   src/health-check/health_checker.cpp 45a5fe00a95a6e88b1990c1396e03082feb202bc 
> 
> Diff: https://reviews.apache.org/r/36816/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message