mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 51083: Passed the pid of the container into `HealthChecker`.
Date Tue, 16 Aug 2016 23:55:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51083/#review145932
-----------------------------------------------------------




src/health-check/health_checker.hpp (line 50)
<https://reviews.apache.org/r/51083/#comment212283>

    1. Don't use `const Option<T>&`, it is not doing what you probably want it to
do : )
    2. s/containerPid/taskPid/ We can create an overlay network and hence require `setns`
for tasks that are not necessarily containers.
    3. Write a comment explaining parameters, `taskPid` in particular, e.g. "The task pid
is used to enter appropriate namespaces".


- Alexander Rukletsov


On Aug. 15, 2016, 3:42 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51083/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2016, 3:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón Kleiman, Gilbert
Song, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-5961
>     https://issues.apache.org/jira/browse/MESOS-5961
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To ensure our health check share same namespaces with the container,
> we need to pass the pid of the container into `HealthChecker` for
> further inspecting and setting.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 8d679cd33b6ddf3a5c11bb8c458a97b8809473ac 
>   src/health-check/health_checker.hpp b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 
>   src/health-check/health_checker.cpp 45a5fe00a95a6e88b1990c1396e03082feb202bc 
>   src/launcher/executor.cpp 2d04edbd58f881f59fca00b95803474724a49154 
> 
> Diff: https://reviews.apache.org/r/51083/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message