mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Review Request 51155: Added an agent flag for 'runtime_dir'.
Date Tue, 16 Aug 2016 22:42:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51155/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Jie Yu.


Bugs: MESOS-6050
    https://issues.apache.org/jira/browse/MESOS-6050


Repository: mesos


Description
-------

Currently, a number of agent components hard code a path
under '/var/run/mesos' in order to persist runtime information across
agent crashes. This path should be configurable.

This commit adds an agent flag to make this runtime directory
configurable. It only lays the groundwork for migrating all of the
hard coded paths. It doesn't actually modify these components yet.
That will come in subsequent commits.


Diffs
-----

  src/slave/constants.hpp 360dd059b21ae3128766ba7abdbffb36d4c3ec13 
  src/slave/flags.hpp ef2394cae5cb72ae627aaef443ac06a50bcfb16f 
  src/slave/flags.cpp c07d6e5e062b75c9dd867e3dced9e2cc8b69872d 
  src/tests/mesos.cpp 62e8fcc6fa7bd856aab6148ca6e6cad66b436f04 

Diff: https://reviews.apache.org/r/51155/diff/


Testing
-------

make -j check
sudo src/mesos-tests
Currently running through CI


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message