mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 50992: Introduce MESOS_{MAJOR|MINOR|PATCH}_VERSION_INT macros.
Date Tue, 16 Aug 2016 21:56:49 GMT


> On Aug. 16, 2016, 9:29 p.m., Avinash sridharan wrote:
> > include/mesos/version.hpp.in, line 27
> > <https://reviews.apache.org/r/50992/diff/2/?file=1473426#file1473426line27>
> >
> >     The `INT` specified seems out of place. We use semantic 2.0 versionign, so it
will more like 'x.x.x', maybe:
> >     s/INT/NUM ?
> 
> Jiang Yan Xu wrote:
>     +1 
>     
>     yeah `_NUM` suffix is probably better and the word "number" is used throughout http://semver.org/
so it doesn't feel odd at all.

Sounds good. Will change INT to NUM


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50992/#review145910
-----------------------------------------------------------


On Aug. 15, 2016, 5:31 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50992/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2016, 5:31 p.m.)
> 
> 
> Review request for mesos, Xiaojian Huang, haosdent huang, James Peach, Joris Van Remoortere,
Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4638
>     https://issues.apache.org/jira/browse/MESOS-4638
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This makes version based conditional compiling much easier for
> module writers.
> 
> 
> Diffs
> -----
> 
>   include/mesos/version.hpp.in c8fbc822d91abb61df15715c0c6af98b0bfe2cb9 
> 
> Diff: https://reviews.apache.org/r/50992/diff/
> 
> 
> Testing
> -------
> 
> make on Mac OS and Linux.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message