mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 51148: Moved MockSlave into a separate header/implementation file.
Date Tue, 16 Aug 2016 21:04:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51148/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

This improves compilation time for the unit tests. There is also
merit in moving related declarations together into a separate,
smaller header file.


Diffs
-----

  src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
  src/tests/mesos.hpp 4cae54b4df906d4b7e8fe8d40d5b0ad59d260e6f 
  src/tests/mesos.cpp 62e8fcc6fa7bd856aab6148ca6e6cad66b436f04 
  src/tests/mock_slave.hpp PRE-CREATION 
  src/tests/mock_slave.cpp PRE-CREATION 
  src/tests/oversubscription_tests.cpp 18da40e92a2717e9729c300799a4790bba379906 
  src/tests/persistent_volume_tests.cpp a6f97c4bb5fb29d610c01255036095e2b30c44c5 
  src/tests/reservation_tests.cpp 6181c6f8abbf254b45ea77f33c48dee918106ef0 
  src/tests/slave_tests.cpp 30ca3da6ca2f1e068bb3f8a6abc7efeebd5bfe8c 

Diff: https://reviews.apache.org/r/51148/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message