mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 51099: Fixed scalar resources output to print full significant digits.
Date Tue, 16 Aug 2016 16:34:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51099/
-----------------------------------------------------------

(Updated Aug. 16, 2016, 9:34 a.m.)


Review request for mesos, Joris Van Remoortere and Neil Conway.


Changes
-------

addressed review comments. Thanks Neil!


Bugs: MESOS-5875
    https://issues.apache.org/jira/browse/MESOS-5875


Repository: mesos


Description
-------

Also clarified in the comments that when we say "We discard any additional precision" we mean
the fractional part.


Diffs (updated)
-----

  src/common/values.cpp cc87d9436f1a75e71cbeb8b709ec323e24f4f519 
  src/tests/resources_tests.cpp e61bdeffd5114ab481903c1178d9ecb3452ec85b 
  src/v1/values.cpp 6e3617ef8cce1b89632d9266878914e472e069b1 

Diff: https://reviews.apache.org/r/51099/diff/


Testing
-------

make check. 

Added a test block which would fail without the change.


Thanks,

Jiang Yan Xu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message