> On Aug. 16, 2016, 2:28 p.m., Qian Zhang wrote:
> > src/tests/containerizer/isolator_tests.cpp, line 1025
> > <https://reviews.apache.org/r/50750/diff/6/?file=1473039#file1473039line1025>
> >
> > I think changing test name from `NetClsIsolatorTest` to `CgroupsIsolatorTest`
will make this test fail, I have verified in Ubuntu 14.04:
> > ```
> > [==========] Running 1 test from 1 test case.
> > [----------] Global test environment set-up.
> > [----------] 1 test from CgroupsIsolatorTest
> > [ RUN ] CgroupsIsolatorTest.ROOT_CGROUPS_NetClsSubsystemIsolate
> > ../../src/tests/containerizer/isolator_tests.cpp:1038: Failure
> > _containerizer: Failed to create isolator 'cgroups/net_cls': Failed to prepare
hierarchy for the subsystem 'net_cls': Failed to mount cgroups hierarchy at '/sys/fs/cgroup/net_cls':
'net_cls' not found
> > [ FAILED ] CgroupsIsolatorTest.ROOT_CGROUPS_NetClsSubsystemIsolate (1734 ms)
> > ```
> > Basically this test should be disabled on Ubuntu 14.04 which does not have `net_cls`
subsystem turned on, please see the following code about why it is not disabled when the test
name is changed.
> > https://github.com/apache/mesos/blob/0d3793e94adcd6dc91d06404f205639cebd753fd/src/tests/environment.cpp#L436:L442
Nice catch! I only test my patches in CentOS 7 before. Let me try the Ubuntu 14.04
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50750/#review145863
-----------------------------------------------------------
On Aug. 15, 2016, 1:12 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50750/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2016, 1:12 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
>
>
> Bugs: MESOS-5976
> https://issues.apache.org/jira/browse/MESOS-5976
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed CgroupsNetClsIsolatorProcess.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324
> src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7
> src/slave/containerizer/mesos/containerizer.cpp 5ed894d18258f6516866a2acd343c03281039c3c
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp b3fd8c85476bf46368bd79f052b7923ad9d32199
> src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp bebefbba7153d4b0e9a8d7179cfb642e6e802bea
> src/tests/containerizer/isolator_tests.cpp f917db78157f799efc00b0c7af0230ddb6f26b0b
>
> Diff: https://reviews.apache.org/r/50750/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
|