mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 51122: Fixed memory leak in agent signal handlers.
Date Tue, 16 Aug 2016 01:34:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51122/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Greg Mann, Artem Harutyunyan, and Vinod Kone.


Repository: mesos


Description
-------

This leak was introduced on purpose in:
https://reviews.apache.org/r/34016/

When we run tests in repetition, each agent will create a new signal
handler and leak the old one.  We can either delete the old signal
handler, or guard this function with a `Once`.


Diffs
-----

  src/slave/posix_signalhandler.hpp 4a5411793e55f912c6e8ae72f9a8042d3a6195b5 

Diff: https://reviews.apache.org/r/51122/diff/


Testing
-------

make check (OSX)

Found this leak via code inspection after valgrind.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message