mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Haris Choudhary <haris0...@gmail.com>
Subject Review Request 51108: Added additional parameters to the CLI config.
Date Mon, 15 Aug 2016 21:54:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51108/
-----------------------------------------------------------

Review request for mesos, Joseph Wu and Kevin Klues.


Bugs: mesos-5676
    https://issues.apache.org/jira/browse/mesos-5676


Repository: mesos


Description
-------

These parameters will be used by future plugins in the CLI. We can either
edit them directly from the config file or discover them through environment
variables. The environment variables override any edits made to the config file.

Also added the ability to format command flags in the base plugin class. This allows
us to not import the config file within individual plugins to do so.
The Key-Value pairs for formatting will be introduced with with future plugins.


Diffs
-----

  src/cli_new/bin/config.py PRE-CREATION 
  src/cli_new/lib/mesos/plugins/base.py PRE-CREATION 

Diff: https://reviews.apache.org/r/51108/diff/


Testing
-------


Thanks,

Haris Choudhary


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message