mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.
Date Mon, 15 Aug 2016 21:21:52 GMT


> On Aug. 13, 2016, 1:02 a.m., Zhitao Li wrote:
> > src/docker/docker.hpp, line 152
> > <https://reviews.apache.org/r/51052/diff/1/?file=1472428#file1472428line152>
> >
> >     Note that this does not apply cleanly anymore, because gmock only generate mocks
for functions with up to 10 arguments, and this is the 11th.
> >     
> >     Working in a next branch to see whther I refactor this `Docker::run()` function
to reduce number of arguments passed in. Any suggestion is welcomed.

Took an idea from @haosent to specify the argument at `Docker::create` instead.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51052/#review145684
-----------------------------------------------------------


On Aug. 15, 2016, 9:21 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51052/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2016, 9:21 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-2154
>     https://issues.apache.org/jira/browse/MESOS-2154
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fixes cpu quota for command executor (which runs outside
> of the docker container) by ensuing --cpu-quota flag to docker
> run.
> 
> Note: we have to add the boolean variable to `Docker` class
> because `Docker::run()` has reached the maximum argument length
> GMOCK can support.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
>   src/docker/docker.cpp e07c4aa723f57db7f8bc31d4af5d32a30ebf98f2 
>   src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 
>   src/docker/executor.cpp 4c08e5d589a64be21fd2396cf575694b126a15c2 
>   src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62 
>   src/tests/containerizer/docker_containerizer_tests.cpp 66adeec1411c71b269ff1d96c379968dab2a407a

>   src/tests/containerizer/docker_tests.cpp e9a214a8973b3dfac69d59e90ce08473baa7eba4 
>   src/tests/environment.cpp 7f144f1763320aef1657a60b293d585b74a83367 
>   src/tests/hook_tests.cpp a1c8685d7ae984a728f5225cae89e3c235b46266 
>   src/tests/mesos.cpp 62e8fcc6fa7bd856aab6148ca6e6cad66b436f04 
> 
> Diff: https://reviews.apache.org/r/51052/diff/
> 
> 
> Testing
> -------
> 
> I am now able to make docker containers launched through mesos-execute have a cpu quota.
> 
> Also making sure `make check` still works on mac os for the linux only flag.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message