mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Re: Review Request 51100: Added a containerizer launch interface to launch sub-containers.
Date Mon, 15 Aug 2016 18:49:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51100/#review145783
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/containerizer.hpp (line 93)
<https://reviews.apache.org/r/51100/#comment212146>

    s/sub/nested/
    
    We should be consistent throughout the code base calling these nested containers. Sound
good?


- Benjamin Hindman


On Aug. 15, 2016, 6:43 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51100/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2016, 6:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Gilbert Song, Kevin Klues, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a containerizer launch interface to launch sub-containers.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.hpp 14f298ead7e91beab1a45cf7b0f9bd2f60f5241a

> 
> Diff: https://reviews.apache.org/r/51100/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message