mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 51061: Added LAUNCH_GROUP offer operation.
Date Mon, 15 Aug 2016 18:29:41 GMT


> On Aug. 13, 2016, 10:18 p.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 1379
> > <https://reviews.apache.org/r/51061/diff/1/?file=1472355#file1472355line1379>
> >
> >     As we want to allow containers share a network namespace and volumes, so I think
that we shoud also highlight `Volume` here.
> 
> Guangya Liu wrote:
>     Another point is I think here you mean 
>     ```
>     2) `NetworkInfo` must not be set inside task's `ContainerInfo`. 
>     ```
>     As the `TaskInfo` has a `resources` field, so using `ContainerInfo` or `container`
for above may be more clear?
>     
>     For the above, what about add a new item for `Volume` as following:
>     ```
>     
>     3) `Volume` can be set in both executor level and task level so as to share a volume
between executor and task.
>     ```

I'll add Volume information on LaunchGroup message because talking about executor here is
a bit weird.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51061/#review145710
-----------------------------------------------------------


On Aug. 12, 2016, 11:12 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51061/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2016, 11:12 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, Benjamin Mahler, James DeFelice,
and Jie Yu.
> 
> 
> Bugs: MESOS-6036
>     https://issues.apache.org/jira/browse/MESOS-6036
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A scheduler can use the LAUNCH_GROUP offer operation to send a
> `TaskGroup` to an executor.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto af29dab2af4c28e257ad518c68d3f1af7cad0d06 
>   include/mesos/v1/mesos.proto a836f6e792944726ec6f8f66f77f403894377d05 
>   src/common/resources.cpp 6b7af9179121efbdc5c29484eb042778bcea8288 
>   src/master/master.cpp 0bd1a3490a86fede86a3f5f62ce4745b65aae258 
>   src/v1/resources.cpp 03ee0cb0bb5abe7fc1ae4cb47c5b6dbcd8d11998 
> 
> Diff: https://reviews.apache.org/r/51061/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message