mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 51060: Made `Offer::Operation::Type` optional with default `UNKNOWN`.
Date Mon, 15 Aug 2016 18:11:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51060/#review145779
-----------------------------------------------------------


Ship it!





src/master/master.cpp (line 3432)
<https://reviews.apache.org/r/51060/#comment212137>

    Hm.. seems like an ERROR if we receive an operation we cannot support?



src/master/master.cpp (line 3871)
<https://reviews.apache.org/r/51060/#comment212138>

    Hm.. seems like an ERROR if we receive an operation we cannot support?


- Benjamin Mahler


On Aug. 12, 2016, 11:10 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51060/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2016, 11:10 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Jie Yu.
> 
> 
> Bugs: MESOS-6036 and MESOS-6037
>     https://issues.apache.org/jira/browse/MESOS-6036
>     https://issues.apache.org/jira/browse/MESOS-6037
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is necessary to introduce new offer operations in a backwards
> compatible manner. See MESOS-4997 for context.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto af29dab2af4c28e257ad518c68d3f1af7cad0d06 
>   include/mesos/v1/mesos.proto a836f6e792944726ec6f8f66f77f403894377d05 
>   src/common/resources.cpp 6b7af9179121efbdc5c29484eb042778bcea8288 
>   src/master/master.cpp 0bd1a3490a86fede86a3f5f62ce4745b65aae258 
>   src/v1/resources.cpp 03ee0cb0bb5abe7fc1ae4cb47c5b6dbcd8d11998 
> 
> Diff: https://reviews.apache.org/r/51060/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message