mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 50992: Introduce MESOS_{MAJOR|MINOR|PATCH}_VERSION_INT macros.
Date Mon, 15 Aug 2016 17:31:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50992/
-----------------------------------------------------------

(Updated Aug. 15, 2016, 5:31 p.m.)


Review request for mesos, Xiaojian Huang, haosdent huang, James Peach, Joris Van Remoortere,
Vinod Kone, and Jiang Yan Xu.


Changes
-------

Introduce int typed version and keep string typed macros around.


Summary (updated)
-----------------

Introduce MESOS_{MAJOR|MINOR|PATCH}_VERSION_INT macros.


Bugs: MESOS-4638
    https://issues.apache.org/jira/browse/MESOS-4638


Repository: mesos


Description
-------

This makes version based conditional compiling much easier for
module writers.


Diffs (updated)
-----

  include/mesos/version.hpp.in c8fbc822d91abb61df15715c0c6af98b0bfe2cb9 

Diff: https://reviews.apache.org/r/50992/diff/


Testing
-------

make on Mac OS and Linux.


Thanks,

Zhitao Li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message