mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 51059: Made `ExecutorInfo.command` optional.
Date Mon, 15 Aug 2016 17:02:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51059/#review145767
-----------------------------------------------------------




include/mesos/mesos.proto (line 505)
<https://reviews.apache.org/r/51059/#comment212127>

    s/mesos/Mesos/
    
    here and below.
    
    also update any documentation in docs/ regarding how to use default executor.


- Vinod Kone


On Aug. 12, 2016, 11:08 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51059/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2016, 11:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, James DeFelice, and Jie Yu.
> 
> 
> Bugs: MESOS-6036
>     https://issues.apache.org/jira/browse/MESOS-6036
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is done to allow schedulers to use `ExecutorInfo` with just
> `executor_id` set. This is a requirement for the upcoming support
> for `TaskGroup` semantics.
> 
> Note that in this patch, TASK_ERROR is returned when
> `ExecutorInfo.command` is unset to keep the existing semantics for
> `LAUNCH` offer operation. This might change when we add `LAUNCH_GROUP`
> operation.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto af29dab2af4c28e257ad518c68d3f1af7cad0d06 
>   include/mesos/v1/mesos.proto a836f6e792944726ec6f8f66f77f403894377d05 
>   src/master/validation.cpp af18e5aef3be59830b0a7b0235bbc739dba1029c 
>   src/tests/master_validation_tests.cpp 9eb82a569f7c48caa96d4d54a93b199ccac74385 
> 
> Diff: https://reviews.apache.org/r/51059/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message