-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50751/#review145721
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (line 437)
<https://reviews.apache.org/r/50751/#comment212075>
I do not think we need this class anymore since you have implemented its logic in `PerfEventSubsystem`.
- Qian Zhang
On Aug. 11, 2016, 10:21 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50751/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2016, 10:21 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
>
>
> Bugs: MESOS-5975
> https://issues.apache.org/jira/browse/MESOS-5975
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed CgroupsPerfEventIsolatorProcess.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 6088c26d3465c3abb908495da3fa5b98c3062d16
> src/Makefile.am 33706e56189eb3f9a571d9aacf1050e188410d7c
> src/slave/containerizer/mesos/containerizer.cpp 86a8d8a85b6a33c87798108cb65af85bb9bbbc77
> src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp 4abde12af68a26b94b3706cdb38bf9890d811039
> src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 31f35385691681ef5da14be747edfb5f57c5d05a
> src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 5f52a076a1fa3a21d886cb961ddeed5046a38d7c
> src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp a30ecafcbecc9d3b6eeea2b04dcb4d278750af41
> src/tests/containerizer/isolator_tests.cpp 4f047ae6b2e85e177e8b73d60b9dfca913c832a5
>
> Diff: https://reviews.apache.org/r/50751/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
|