mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.
Date Sun, 14 Aug 2016 04:13:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40266/#review145715
-----------------------------------------------------------




3rdparty/libprocess/src/process.cpp (line 413)
<https://reviews.apache.org/r/40266/#comment212065>

    `all` is a bit misleading since "gc" is not being terminated. can you just call it "terminate"?
i know there is already a process specific overload. or maybe call it "finalize" ?



3rdparty/libprocess/src/process.cpp (line 1123)
<https://reviews.apache.org/r/40266/#comment212066>

    s/`process_manager`/`process_manager->finalize()`/



3rdparty/libprocess/src/process.cpp (line 1132)
<https://reviews.apache.org/r/40266/#comment212067>

    ha. you are calling it "finalizing" here.



3rdparty/libprocess/src/process.cpp (line 1136)
<https://reviews.apache.org/r/40266/#comment212068>

    but all the processes are already terminated by this point? do you mean just the gc process
my dereference it?



3rdparty/libprocess/src/process.cpp (line 1147)
<https://reviews.apache.org/r/40266/#comment212069>

    do you  mean just the `gc` process?



3rdparty/libprocess/src/process.cpp (line 1163)
<https://reviews.apache.org/r/40266/#comment212070>

    but process manager is cleaned up above?



3rdparty/libprocess/src/process.cpp (line 2397)
<https://reviews.apache.org/r/40266/#comment212072>

    move this to #2403



3rdparty/libprocess/src/process.cpp (lines 2403 - 2410)
<https://reviews.apache.org/r/40266/#comment212073>

    why do this here instead of #1155?



3rdparty/libprocess/src/process.cpp (line 2790)
<https://reviews.apache.org/r/40266/#comment212074>

    add a TODO to return Try here?


- Vinod Kone


On Aug. 12, 2016, 9 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40266/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2016, 9 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, and Vinod
Kone.
> 
> 
> Bugs: MESOS-3910
>     https://issues.apache.org/jira/browse/MESOS-3910
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `SocketManager` and `ProcessManager` are highly inter-dependent, 
> which requires some untangling in `process::finalize`.
> 
> * Logic originally found in `~ProcessManager` has been split into 
>   `ProcessManager::finalize` due to what happens during cleanup.
> * The future from `__s__->accept()` must be explicitly discarded as 
>   libevent does not detect a locally closed socket.
> * Terminating `HttpProxy`s must close the associated socket.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 629f1644bc0a263972ec9efc41890c33f9406a34 
> 
> Diff: https://reviews.apache.org/r/40266/diff/
> 
> 
> Testing
> -------
> 
> `make check` (libev)
> `make check` (--enable-libevent --enable-ssl)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message