-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51068/#review145706
-----------------------------------------------------------
Hi Aaron,
Awesome, thanks for your contribution! Two quick suggestions:
(1) Is there a workload/tool that repros the memory leak? e.g., it would be good to be able
to say that "when you do X (e.g., run unit test X) under `valgrind --leak-check=full`, there
was previously a memory leak of X bytes; with these changes, the leak is instead Y bytes."
(2) When contributing to Mesos, we try to encourage people to find a shepherd (Mesos committer)
to work with to get your changes committed (https://mesos.apache.org/documentation/latest/submitting-a-patch/).
I've pinged a few committers, so hopefully someone volunteers -- otherwise, you can find people
in the `#dev` channel on Slack, IRC, or the dev mailing list.
- Neil Conway
On Aug. 13, 2016, 8:08 a.m., Aaron Wood wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51068/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2016, 8:08 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This should prevent any of the promises that are created in the various ZookeeperProcess
class methods from leaking memory.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 3f06000
> src/zookeeper/zookeeper.cpp e105377
>
> Diff: https://reviews.apache.org/r/51068/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Aaron Wood
>
>
|