-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49851/#review145698
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp (lines 69 - 73)
<https://reviews.apache.org/r/49851/#comment212047>
I would suggest to move this method right after the `cleanup()` method.
- Qian Zhang
On Aug. 11, 2016, 10:19 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49851/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2016, 10:19 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
>
>
> Bugs: MESOS-5045
> https://issues.apache.org/jira/browse/MESOS-5045
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented `MemorySubsystem`.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp b191b2a52a9645fc902a35ed52909b2142f0b4c0
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 2659252d8cffcefc233bc85fb4707c8147272737
> src/slave/containerizer/mesos/isolators/cgroups/constants.hpp c45d88092f3fe497373dfeaa8346aef9126c7b8b
> src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 5f52a076a1fa3a21d886cb961ddeed5046a38d7c
> src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp a30ecafcbecc9d3b6eeea2b04dcb4d278750af41
>
> Diff: https://reviews.apache.org/r/49851/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
|