mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.
Date Sat, 13 Aug 2016 01:02:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51052/#review145684
-----------------------------------------------------------




src/docker/docker.hpp (line 152)
<https://reviews.apache.org/r/51052/#comment212037>

    Note that this does not apply cleanly anymore, because gmock only generate mocks for functions
with up to 10 arguments, and this is the 11th.
    
    Working in a next branch to see whther I refactor this `Docker::run()` function to reduce
number of arguments passed in. Any suggestion is welcomed.


- Zhitao Li


On Aug. 13, 2016, 1 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51052/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2016, 1 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-2154
>     https://issues.apache.org/jira/browse/MESOS-2154
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This fixes cpu quota for command executor (which runs outside
> of the docker container) by ensuing --cpu-quota flag to docker
> run.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
>   src/docker/docker.cpp e07c4aa723f57db7f8bc31d4af5d32a30ebf98f2 
>   src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 
>   src/docker/executor.cpp 4c08e5d589a64be21fd2396cf575694b126a15c2 
>   src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62 
> 
> Diff: https://reviews.apache.org/r/51052/diff/
> 
> 
> Testing
> -------
> 
> I am now able to make docker containers launched through mesos-execute have a cpu quota.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message