mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.
Date Fri, 12 Aug 2016 23:05:46 GMT


> On Aug. 11, 2016, 7:48 p.m., Joseph Wu wrote:
> > src/tests/scheduler_tests.cpp, line 1643
> > <https://reviews.apache.org/r/50857/diff/2/?file=1470454#file1470454line1643>
> >
> >     This is already called in `MesosTest::SetUp()`.

AFAICT this isn't called in `MesosTest::SetUp()` anywhere. If I remove this line, the test
fails because the keys/certs haven't been written.


> On Aug. 11, 2016, 7:48 p.m., Joseph Wu wrote:
> > src/tests/scheduler_tests.cpp, lines 1657-1668
> > <https://reviews.apache.org/r/50857/diff/2/?file=1470454#file1470454line1657>
> >
> >     Since we're already reinitializing in the `SetUp`, we don't need to reinitialize
in `TearDown`.
> >     
> >     Instead, change this cleanup to `TearDownTestCase`.

We have to reinitialize conditionally to clear the environment for non-SSL iterations. If
we make this a `TearDownTestCase`, we won't successfully alternate between enabled/disabled
SSL.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/#review145549
-----------------------------------------------------------


On Aug. 12, 2016, 11:03 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50857/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2016, 11:03 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-3753
>     https://issues.apache.org/jira/browse/MESOS-3753
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch modifies the test `SchedulerTest.Teardown` to
> be parametrized by both `ContentType` and SSL configuration,
> and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
> This allows the test to verify the scheduler's behavior with
> SSL both enabled and disabled.
> 
> 
> Diffs
> -----
> 
>   src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 
> 
> Diff: https://reviews.apache.org/r/50857/diff/
> 
> 
> Testing
> -------
> 
> This test is currently flaky in the SSL-enabled configurations and will produce a segfault
on my OSX machine after 50-100 repetitions. To reproduce, try:
> 
> `GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE=1 GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2"
bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message