mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.
Date Fri, 12 Aug 2016 23:03:23 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 12, 2016, 11:03 p.m.)

Review request for mesos, Joseph Wu and Vinod Kone.


Addressed Joseph's comments.

Bugs: MESOS-3753

Repository: mesos


This patch modifies the test `SchedulerTest.Teardown` to
be parametrized by both `ContentType` and SSL configuration,
and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.

Diffs (updated)

  src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 



This test is currently flaky in the SSL-enabled configurations and will produce a segfault
on my OSX machine after 50-100 repetitions. To reproduce, try:

`GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE=1 GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2"


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message