mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 50912: Added the infrastructure for a new python-based CLI.
Date Fri, 12 Aug 2016 22:55:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50912/#review145442
-----------------------------------------------------------



Overall, code looks reasonable.


configure.ac (lines 1803 - 1806)
<https://reviews.apache.org/r/50912/#comment212007>

    Can you add a comment saying that we already check for python > 2.6 about 500 lines
up (`--enable-python`)?



src/cli_new/bin/config.py (line 35)
<https://reviews.apache.org/r/50912/#comment212013>

    There's a tab here.  Is that intentional?



src/cli_new/bootstrap (line 17)
<https://reviews.apache.org/r/50912/#comment212008>

    s/activates/activated/



src/cli_new/bootstrap (lines 34 - 38)
<https://reviews.apache.org/r/50912/#comment212009>

    Here you check for python 2.7.  But the configure file allows python 2.6 too.



src/cli_new/mesos.bash_completion (lines 1 - 3)
<https://reviews.apache.org/r/50912/#comment212012>

    It would be nice to have a quick comment here explaining the bash magic.


- Joseph Wu


On Aug. 11, 2016, 3:23 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50912/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2016, 3:23 p.m.)
> 
> 
> Review request for mesos, Haris Choudhary and Joseph Wu.
> 
> 
> Bugs: MESOS-6008
>     https://issues.apache.org/jira/browse/MESOS-6008
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the infrastructure for a new python-based CLI.
> 
> 
> Diffs
> -----
> 
>   configure.ac f82c6314d65a8ea3eb118bab8e110063cae46121 
>   docs/getting-started.md ebe52705b8c8757d4a507ce3ae75f56d535a39d1 
>   src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
>   src/cli_new/README.md PRE-CREATION 
>   src/cli_new/activate PRE-CREATION 
>   src/cli_new/bin/config.py PRE-CREATION 
>   src/cli_new/bin/main.py PRE-CREATION 
>   src/cli_new/bin/mesos PRE-CREATION 
>   src/cli_new/bootstrap PRE-CREATION 
>   src/cli_new/deactivate PRE-CREATION 
>   src/cli_new/lib/mesos/__init__.py PRE-CREATION 
>   src/cli_new/lib/mesos/docopt.py PRE-CREATION 
>   src/cli_new/lib/mesos/exceptions.py PRE-CREATION 
>   src/cli_new/lib/mesos/plugins/__init__.py PRE-CREATION 
>   src/cli_new/lib/mesos/plugins/base.py PRE-CREATION 
>   src/cli_new/lib/mesos/util.py PRE-CREATION 
>   src/cli_new/mesos.bash_completion PRE-CREATION 
>   src/cli_new/pip-requirements.txt PRE-CREATION 
>   src/cli_new/pylint.config PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50912/diff/
> 
> 
> Testing
> -------
> 
> ../configure --enable-new-cli
> make -C src mesos
> src/mesos
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message