mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.
Date Fri, 12 Aug 2016 21:00:23 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 12, 2016, 2 p.m.)

Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.


Added guards for using `process::spawn` after `process::finalize`.  We should not segfault
in this case.

Bugs: MESOS-3910

Repository: mesos


The `SocketManager` and `ProcessManager` are highly inter-dependent, 
which requires some untangling in `process::finalize`.

* Logic originally found in `~ProcessManager` has been split into 
  `ProcessManager::finalize` due to what happens during cleanup.
* The future from `__s__->accept()` must be explicitly discarded as 
  libevent does not detect a locally closed socket.
* Terminating `HttpProxy`s must close the associated socket.

Diffs (updated)

  3rdparty/libprocess/src/process.cpp 629f1644bc0a263972ec9efc41890c33f9406a34 



`make check` (libev)
`make check` (--enable-libevent --enable-ssl)


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message