> On Aug. 11, 2016, 5:14 p.m., Greg Mann wrote:
> > 3rdparty/libprocess/src/process.cpp, line 1126
> > <https://reviews.apache.org/r/40266/diff/6/?file=1468609#file1468609line1126>
> >
> > Is it intentional to call this twice; once here and once in the process manager's
destructor?
Yup, it's intentional, and more to be safe than to be correct. There is a small gap between
the first call and `delete process_manager`, which is enough to spawn a couple new processes.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40266/#review145578
-----------------------------------------------------------
On Aug. 8, 2016, 6:18 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40266/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2016, 6:18 p.m.)
>
>
> Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, and Vinod
Kone.
>
>
> Bugs: MESOS-3910
> https://issues.apache.org/jira/browse/MESOS-3910
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `SocketManager` and `ProcessManager` are highly inter-dependent,
> which requires some untangling in `process::finalize`.
>
> * Logic originally found in `~ProcessManager` has been split into
> `ProcessManager::finalize` due to what happens during cleanup.
> * The future from `__s__->accept()` must be explicitly discarded as
> libevent does not detect a locally closed socket.
> * Terminating `HttpProxy`s must close the associated socket.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 629f1644bc0a263972ec9efc41890c33f9406a34
>
> Diff: https://reviews.apache.org/r/40266/diff/
>
>
> Testing
> -------
>
> `make check` (libev)
> `make check` (--enable-libevent --enable-ssl)
>
>
> Thanks,
>
> Joseph Wu
>
>
|