mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 49849: Implemented `CpuSubsystem`.
Date Fri, 12 Aug 2016 19:07:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49849/#review145628
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (line 148)
<https://reviews.apache.org/r/49849/#comment211941>

    Instead of having a `load` in the base class. Can we just have a `create` function for
each subsystem?



src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (line 165)
<https://reviews.apache.org/r/49849/#comment211942>

    Let's move cpu subsystem related code into `cgroups/subsystems/cpu.hpp|cpp`



src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (line 51)
<https://reviews.apache.org/r/49849/#comment211943>

    see my comments above, let's just have a CpuSubsystem::create method


- Jie Yu


On Aug. 11, 2016, 2:19 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49849/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2016, 2:19 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5042
>     https://issues.apache.org/jira/browse/MESOS-5042
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented `CpuSubsystem`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 2659252d8cffcefc233bc85fb4707c8147272737

>   src/slave/containerizer/mesos/isolators/cgroups/constants.hpp c45d88092f3fe497373dfeaa8346aef9126c7b8b

>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 5f52a076a1fa3a21d886cb961ddeed5046a38d7c

>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp a30ecafcbecc9d3b6eeea2b04dcb4d278750af41

> 
> Diff: https://reviews.apache.org/r/49849/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message