-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36181/#review145638
-----------------------------------------------------------
src/slave/containerizer/docker.cpp (lines 145 - 147)
<https://reviews.apache.org/r/36181/#comment211956>
Maybe just
```
return Error("Docker with CFS support requires docker 1.7+: " + validateResult.error());
```
src/slave/containerizer/docker.cpp (lines 293 - 296)
<https://reviews.apache.org/r/36181/#comment211957>
Do we want to handle `cpu-period` flag only in this location?
In fact, I don't think this period handling is very consistent right now: There are other
places using arithmetic calculation from `CPU_CFS_PERIOD`, and things will be badly off if
it's different from system default.
I think we probably should either 1) perform valiation that `CPU_CFS_PERIOD` is consistent
with local system default, or 2) simply detect local system default and use it for `CPU_CFS_PERIOD`.
- Zhitao Li
On Oct. 4, 2015, 6:40 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36181/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2015, 6:40 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-2154
> https://issues.apache.org/jira/browse/MESOS-2154
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Port CFS support to Docker Containerizer
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf
>
> Diff: https://reviews.apache.org/r/36181/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
|