mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 51014: Removed one blank space in allocator benchmark test 'DeclineOffers'.
Date Fri, 12 Aug 2016 09:10:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51014/#review145602
-----------------------------------------------------------



Patch looks great!

Reviews applied: [50693, 50695, 50866, 50868, 51014]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Aug. 11, 2016, 11:30 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51014/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2016, 11:30 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed one blank space in allocator benchmark test 'DeclineOffers'.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp cbed333f497016fe2811f755028796012b41db77

> 
> Diff: https://reviews.apache.org/r/51014/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> After fix:
> ```
> [ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/0
> Using 1000 agents and 1 frameworks
> Added 1 frameworks in 3011us
> Added 1000 agents in 445145us
> round 0 allocate() took 161072us to make 0 offers after filtering 1000 offers
> round 1 allocate() took 157639us to make 0 offers after filtering 1000 offers
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message