mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.
Date Fri, 12 Aug 2016 02:18:21 GMT


> On 八月 4, 2016, 3:04 p.m., Guangya Liu wrote:
> > src/tests/containerizer/nvidia_gpu_isolator_tests.cpp, line 758
> > <https://reviews.apache.org/r/50127/diff/3/?file=1460569#file1460569line758>
> >
> >     Do you need this with docker containerizer?
> 
> Yubo Li wrote:
>     Currently we need. When I remove this line, the test reports error:
>     resources: '--nvidia_gpus_devices' can only be specified if the `--isolation` flag
contains 'gpu/nvidia'.
>     
>     Actually, docker containerizer does not need `--isolation`, but currently `--nvidia_gpus_devices`
forces us to do this. We would talk with Ben and Kevin to remove this retriction for docker
containerizer soon.
> 
> Guangya Liu wrote:
>     I see, did you initate any discussion with them?

This was fixed in https://reviews.apache.org/r/50947/


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50127/#review144762
-----------------------------------------------------------


On 八月 10, 2016, 10:32 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50127/
> -----------------------------------------------------------
> 
> (Updated 八月 10, 2016, 10:32 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This added a testing case for end-to-end GPU support for docker
> containerizer.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 4e5b1fd1628504d346cced545f7911d6b6443773

> 
> Diff: https://reviews.apache.org/r/50127/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message