mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 51009: Collect throttle related cpu.stat for Docker Containerizer.
Date Thu, 11 Aug 2016 22:18:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51009/#review145567
-----------------------------------------------------------




src/slave/containerizer/docker.cpp (line 1744)
<https://reviews.apache.org/r/51009/#comment211851>

    Note: Existing code seems to always assume `cpu` and `cpuacct` is mounted at the same
location, but I doubt this is a linux rule.
    
    Happy to undo these changes if someone can confirm.


- Zhitao Li


On Aug. 11, 2016, 10:17 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51009/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2016, 10:17 p.m.)
> 
> 
> Review request for mesos, Xiaojian Huang, Gilbert Song, Jie Yu, and Steve Niemitz.
> 
> 
> Bugs: MESOS-6031
>     https://issues.apache.org/jira/browse/MESOS-6031
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Collect throttle related cpu.stat for Docker Containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62 
> 
> Diff: https://reviews.apache.org/r/51009/diff/
> 
> 
> Testing
> -------
> 
> Run agent with cfs quota enabled, and observe that throttle related metrics are in `/containers`
and `/monitoring/statistics`
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message