mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 50910: Added a python linter to mesos-style.cpp.
Date Thu, 11 Aug 2016 21:23:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50910/#review145560
-----------------------------------------------------------




support/mesos-style.py (line 215)
<https://reviews.apache.org/r/50910/#comment211847>

    Since this is an internal function, I would prefix it with "`__`".



support/mesos-style.py (line 217)
<https://reviews.apache.org/r/50910/#comment211846>

    Do you really need this temporary variable if you just use it once. Why not do the `os.path.join()`
directly in the `isdir()` call?



support/mesos-style.py (line 244)
<https://reviews.apache.org/r/50910/#comment211843>

    You don't use this variable anywhere.



support/mesos-style.py (lines 250 - 251)
<https://reviews.apache.org/r/50910/#comment211845>

    I would either call the format strings in here "virtualenv_dir", "lib_dir", and "bin_dir"
or just "virtualenv", "bin", and "lib". Having a "p" at the end of the variable names is confusing
and inconsistent (at least with the name "virtualenv").



support/mesos-style.py (line 251)
<https://reviews.apache.org/r/50910/#comment211850>

    There seems to be an extra space here.



support/mesos-style.py (line 258)
<https://reviews.apache.org/r/50910/#comment211848>

    It looks like there is 1 extra space here.


- Kevin Klues


On Aug. 11, 2016, 8:02 p.m., Haris Choudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50910/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2016, 8:02 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: Mesos-6006
>     https://issues.apache.org/jira/browse/Mesos-6006
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It currently doesn't run over any files in the code base, but we will
> be adding the new python CLI in a subsequent commit, which will use
> this new linter.
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 
> 
> Diff: https://reviews.apache.org/r/50910/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Haris Choudhary
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message