mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 50907: Abstracted mesos-style.py to wrap the cpp linter in a class.
Date Thu, 11 Aug 2016 18:26:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50907/
-----------------------------------------------------------

(Updated Aug. 11, 2016, 6:26 p.m.)


Review request for mesos, Jie Yu and Vinod Kone.


Changes
-------

Addressed Joseph's comments.


Bugs: MESOS-6006
    https://issues.apache.org/jira/browse/MESOS-6006


Repository: mesos


Description
-------

Previously, mesos-style.py was just a collection of functions that
checked the style of relevant files in the mesos code base.  However,
the script assumed that we always wanted to run cpplint over every
file we were checking. Since we are planning on adding a python linter
to the codebase soon, it makes sense to abstract the common
functionality from this script into a class so that a cpp-based linter
and a python-based linter can inherit the same set of common
functionality.

This commit builds this abstraction and implements a 'CppLinter()' in
terms of it.


Diffs (updated)
-----

  support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 

Diff: https://reviews.apache.org/r/50907/diff/


Testing
-------

Ran `support/mesos-style.py` over the whole code base.


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message