mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.
Date Thu, 11 Aug 2016 18:02:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46825/#review145534
-----------------------------------------------------------



Bad patch!

Reviews applied: [46825, 46824, 46823, 46822, 46821]

Failed command: ./support/apply-review.sh -n -r 46822

Error:
2016-08-11 18:01:48 URL:https://reviews.apache.org/r/46822/diff/raw/ [16997/16997] -> "46822.patch"
[1]
error: patch failed: src/health-check/health_checker.hpp:224
error: src/health-check/health_checker.hpp: patch does not apply
error: patch failed: src/tests/containerizer/launcher.hpp:65
error: src/tests/containerizer/launcher.hpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/14755/console

- Mesos ReviewBot


On Aug. 11, 2016, 4:33 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46825/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2016, 4:33 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
>     https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fully-typed all FlagsBase::add overloads.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/flags.hpp bc4684d499bad6e409953f608330325c4a13d6a6 
>   3rdparty/stout/include/stout/flags/flags.hpp 4ca6c69aeb1e3343e9b0ae2562c450c4c645890c

>   3rdparty/stout/tests/flags_tests.cpp 94ba915c40836e476cf6097274a85c55acd4d73b 
>   3rdparty/stout/tests/subcommand_tests.cpp 9213d6b9faec30b5be320ab37ca29c2406c964ac

> 
> Diff: https://reviews.apache.org/r/46825/diff/
> 
> 
> Testing
> -------
> 
> make check (OS X clang-trunk w/o optimizations)
> 
> The mesos tests suite do not execute at all with an optimizing clang-trunk since copying
of the `map` inside `FlagsBase` reference random memory leading to `SEGFAULTs`. With these
patches all of `stout-tests` and `libprocess-tests` can be executed, but some remaining failures
persist in `mesos-tests` (their number is reduced though).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message