> On Aug. 11, 2016, 5:12 p.m., James Peach wrote:
> > As mentioned on chat, I think this will break some external module builds. I'm fine
with that, just pointing it out for posterity.
> >
> > I noticed that the Java bindings use these in the MesosNativeLibrary.Version class.
The Java side of the bindings says this is a ``jlong``, but prior to this change it would
have been a string AFAICT. So I guess this fixes that too?
>
> Zhitao Li wrote:
> I added as many people who might know what existing module already exists as I can
think of, but feel free to suggest more.
>
> If we want to provide a upgrade cycle, we can keep current macros unchanged and define
new ones like
>
> ```
> // TODO: Remove after migration cycle.
> #define MESOS_MAJOR_VERSION "@MESOS_MAJOR_VERSION@"
> #define MESOS_MAJOR_VERSION_INT @MESOS_MAJOR_VERSION@
> ```
>
> Just decided to roll forward faster until someone told me this could actually break
something.
>
> James Peach wrote:
> Yup, good plan. +1
+1 for this changes.
And I think we need to sending a seprate email about
```
I think this will break some external module builds
```
to modules@mesos.apache.org and dev@mesos.apache.org
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50992/#review145522
-----------------------------------------------------------
On Aug. 11, 2016, 5 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50992/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2016, 5 p.m.)
>
>
> Review request for mesos, Xiaojian Huang, haosdent huang, James Peach, Joris Van Remoortere,
Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-4638
> https://issues.apache.org/jira/browse/MESOS-4638
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This makes version based conditional compiling much easier for
> module writers.
>
>
> Diffs
> -----
>
> include/mesos/version.hpp.in c8fbc822d91abb61df15715c0c6af98b0bfe2cb9
>
> Diff: https://reviews.apache.org/r/50992/diff/
>
>
> Testing
> -------
>
> make on Mac OS and Linux.
>
>
> Thanks,
>
> Zhitao Li
>
>
|