mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.
Date Thu, 11 Aug 2016 16:33:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/
-----------------------------------------------------------

(Updated Aug. 11, 2016, 6:32 p.m.)


Review request for mesos, Alexander Rukletsov, Michael Park, and Vinod Kone.


Changes
-------

Rebased.


Bugs: MESOS-3335
    https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
-------

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs (updated)
-----

  src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76 
  src/cli/resolve.cpp 3a12f123e0969382a79d045c15f372e2f5eea02e 
  src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 
  src/examples/balloon_framework.cpp 5613ff0c61e2d2f84684a206debc97dcb8b2c0d3 
  src/examples/disk_full_framework.cpp ad304fee94d443125a0dec2b2820267c69508621 
  src/examples/dynamic_reservation_framework.cpp 850bb2a5b243dd5d5a8b6476570b4f943fde6185

  src/examples/load_generator_framework.cpp 5402e31b89b7ead1dc8fdc9065980b5b1c0d380c 
  src/examples/long_lived_framework.cpp 7c57eb5e4a34208504475013690ae8e3cae74155 
  src/examples/no_executor_framework.cpp 57425726aa5ca27c9579b0d8ecc0bb9eb9b26852 
  src/examples/persistent_volume_framework.cpp fe2837cfffb6dd251ccb9c93197f623d0c55fb36 
  src/examples/test_framework.cpp a83766a92617d50eadd92ec55113e049a7290d03 
  src/examples/test_http_framework.cpp 441e86c88b035d9a268b8b51b95da3e1eb842a62 
  src/launcher/executor.cpp 7967684e42c97326770bd83a41c2d4b1338a511f 
  src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
  src/master/main.cpp 4a1a8e70ab0535aa131681b2b09a99e51c20158e 
  src/slave/container_loggers/lib_logrotate.hpp f216548ef37f5c2245ef64d21e84e06100e8e5ae 
  src/slave/container_loggers/logrotate.hpp 96697d46ca71e7f62119f2fe669230cf5a04242f 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 760d32bf3dc09f3b715b378f5ded41556f15fe41

  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 92f3c07e285ad3b8ef26692aa6475d755188b469

  src/slave/containerizer/mesos/launch.cpp 2db8db5ac2f4614d406b950a1b4e8098a0d90e7b 
  src/slave/containerizer/mesos/mount.cpp dbd7853a43ee1402f2f91d933a657010efdd76b0 
  src/slave/main.cpp 8c9d241890ffa85f88096385e07789e6fc945ddb 

Diff: https://reviews.apache.org/r/46824/diff/


Testing
-------

Tested on various platforms in internal CI.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message