mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomasz Janiszewski <jani...@gmail.com>
Subject Re: Review Request 50851: Decode Protobuf long int form strings.
Date Thu, 11 Aug 2016 08:49:09 GMT


> On Aug. 10, 2016, 11:53 p.m., Joseph Wu wrote:
> > Can you add the reason/motivation for this change in your patch description?

@Josheph I added description and fixed/commented issues. Would you like to review it one mor
time.


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50851/#review145430
-----------------------------------------------------------


On Aug. 11, 2016, 8:47 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50851/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2016, 8:47 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Joseph Wu.
> 
> 
> Bugs: MESOS-5995
>     https://issues.apache.org/jira/browse/MESOS-5995
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> According to Protobuf JSON mapping long integers
> should be stored as strings.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/protobuf.hpp 91305e104c01d649bd435a27b159540222236c27

>   3rdparty/stout/tests/protobuf_tests.cpp 8877e8934e0f7875bfedcfa88b491ce4b13ca44f 
> 
> Diff: https://reviews.apache.org/r/50851/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message