mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 50922: Moved the implementation of health check to health_checker.cpp.
Date Wed, 10 Aug 2016 21:37:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50922/#review145398
-----------------------------------------------------------


Fix it, then Ship it!





src/health-check/health_checker.hpp 
<https://reviews.apache.org/r/50922/#comment211620>

    This should stay as long as you keep the c-tor definition in the .hpp.



src/health-check/health_checker.hpp (line 25)
<https://reviews.apache.org/r/50922/#comment211622>

    owned.hpp and time.hpp are missing, as well as stout/nothing.hpp



src/health-check/health_checker.hpp 
<https://reviews.apache.org/r/50922/#comment211623>

    We usually declare the *Process class after the wrapper.



src/health-check/health_checker.hpp (lines 35 - 44)
<https://reviews.apache.org/r/50922/#comment211621>

    We can move the c-tor definition to the .cpp as well.



src/health-check/health_checker.cpp (line 39)
<https://reviews.apache.org/r/50922/#comment211627>

    According our style guide, the header should be included first.



src/health-check/health_checker.cpp (line 230)
<https://reviews.apache.org/r/50922/#comment211625>

    Extra blank line.


- Alexander Rukletsov


On Aug. 9, 2016, 6:13 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50922/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2016, 6:13 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved the implementation of health check to health_checker.cpp.
> 
> 
> Diffs
> -----
> 
>   src/health-check/health_checker.hpp b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
>   src/health-check/health_checker.cpp 585a0b565d948cfa292bad818a710501a4ce0daf 
> 
> Diff: https://reviews.apache.org/r/50922/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message