mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 50910: Added a python linter to mesos-style.cpp.
Date Wed, 10 Aug 2016 04:53:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50910/#review145305
-----------------------------------------------------------




support/mesos-style.py (line 219)
<https://reviews.apache.org/r/50910/#comment211487>

    is this the right URL?



support/mesos-style.py (line 227)
<https://reviews.apache.org/r/50910/#comment211488>

    s/pylint_proc/p/ to be consistent with CppLinter()



support/mesos-style.py (lines 228 - 234)
<https://reviews.apache.org/r/50910/#comment211489>

    this indentation looks weird? or is it just RB?



support/mesos-style.py (line 238)
<https://reviews.apache.org/r/50910/#comment211491>

    this looks different than how we extracted stderr in CppLinter(); can we make it consistent?



support/mesos-style.py (line 242)
<https://reviews.apache.org/r/50910/#comment211490>

    Don't follow this comment?


- Vinod Kone


On Aug. 8, 2016, 10:10 p.m., Haris Choudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50910/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2016, 10:10 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Vinod Kone.
> 
> 
> Bugs: Mesos-6006
>     https://issues.apache.org/jira/browse/Mesos-6006
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It currently doesn't run over any files in the code base, but we will
> be adding the new python CLI in a subsequent commit, which will use
> this new linter.
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 
> 
> Diff: https://reviews.apache.org/r/50910/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Haris Choudhary
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message