mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 50621: Libprocess reinit: Moved HttpProxy finalization and destruction.
Date Tue, 09 Aug 2016 01:07:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50621/
-----------------------------------------------------------

(Updated Aug. 8, 2016, 6:07 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.


Changes
-------

Rebase and remove initialization code (unused).


Bugs: MESOS-3910
    https://issues.apache.org/jira/browse/MESOS-3910


Repository: mesos


Description (updated)
-------

Moves the destructor code in `HttpProxy` into the `Process::finalize`
function.  And changes the `HttpProxy`s termination logic to 
terminate via `UPID` which guards against double-termination.

Removes some unused initialization code, too.


Diffs (updated)
-----

  3rdparty/libprocess/src/process.cpp 629f1644bc0a263972ec9efc41890c33f9406a34 

Diff: https://reviews.apache.org/r/50621/diff/


Testing (updated)
-------

make

(More testing done later in the chain)


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message