mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 50763: Updated Linux 'MountInfoTable' entries to be sorted as expected.
Date Mon, 08 Aug 2016 21:57:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50763/#review145140
-----------------------------------------------------------


Fix it, then Ship it!





src/linux/fs.cpp (line 120)
<https://reviews.apache.org/r/50763/#comment211309>

    Any reason use pointer here? Can you use the same move optimization as you did below?


- Jie Yu


On Aug. 5, 2016, 6:45 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50763/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2016, 6:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-5969
>     https://issues.apache.org/jira/browse/MESOS-5969
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Many places in the codebase assume that the mountinfo table is sorted
> according to the order: 'parent mount point < child mount point'.
> 
> However, in some cases this may not be true if (for example), a parent
> mount point (say '/') is remounted to add some extra flags to it.
> When this happens, the remounted file system will appear in the
> mountinfo table at the point where it was remounted.
> 
> We actually encountered this problem in the wild for the case of '/'
> being remounted after '/run' was mounted -- causing problems in the
> 'NvidiaVolume' which assumes the 'parent < child' ordering.
> 
> This commit fixes this problem by building the list of MountInfoTable
> entries in sorted order when 'read()' is called. An optional flag can
> be used to disable sorting produce the the original ordering.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.hpp ec3b5b8cd6926b1f69ad499de1c13b989766a84e 
>   src/linux/fs.cpp f57db80ad0d7235d47910e05d663c77e233f8228 
>   src/tests/containerizer/fs_tests.cpp 4cfafad28daac6bed849992a254660117d7ff30b 
> 
> Diff: https://reviews.apache.org/r/50763/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="" make -j check
> src/mesos-tests
> sudo src/mesos-tests
> 
> Appeared to have one unrelated flaky test fail: `ResourceOffersTest.ResourcesGetReofferedAfterTaskInfoError`
> Rerunning the tests a second time passed.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message