mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaojin CAO <caogao...@cmss.chinamobile.com>
Subject Re: Review Request 50887: Trimmed unneeded extra space between right angle brackets.
Date Mon, 08 Aug 2016 16:13:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50887/
-----------------------------------------------------------

(Updated Aug. 8, 2016, 4:13 p.m.)


Review request for mesos, Benjamin Bannier, Guangya Liu, and haosdent huang.


Bugs: MESOS-5830
    https://issues.apache.org/jira/browse/MESOS-5830


Repository: mesos


Description
-------

Mesos codebase has been evolved and no more need an extra space
between two right angle brackets, e.g. vector<Option<int> >, to
work around C++98 parsing deficiencies(see MESOS-5830).


Diffs (updated)
-----

  include/mesos/log/log.hpp 0f69848bd72372e7a58f6e3789e86bf826eaeab7 
  include/mesos/zookeeper/contender.hpp 0ef9d56c15c4c5dd1d36f2866324ac95d55901d1 
  include/mesos/zookeeper/detector.hpp a953997b98e1242bea10efc791e2f31fa3252593 
  src/authentication/cram_md5/auxprop.cpp 85403417c8169c0796ffa16484aa85da2d5220ba 
  src/cli/mesos.cpp 81e2325c1978d56487479848966115ffd14b7cb0 
  src/cli/resolve.cpp ac6be05e64c5e66703081068d992ebb0d6ca6c70 
  src/files/files.cpp 793d68ec700c792fc9dd73b09ee2616108b88f4f 
  src/java/jni/org_apache_mesos_Log.cpp 04f8afd99b4383e7941a93bfd565806a9988c870 
  src/java/jni/org_apache_mesos_state_AbstractState.cpp 3101352e42e8505a93d8760ad657d9fe35761080

  src/launcher/executor.cpp 9333dc0832cd04305e307ce750195c0fbc860ab2 
  src/linux/ns.hpp e905aefe5ab178c8471cfe801e6432540d3dea67 
  src/log/consensus.cpp 27f2c58c4c54cc3fe5b92873261096b6011ff15d 
  src/log/coordinator.hpp 9fa4f1988c531a9765c9522a017b39fafb0a9cea 
  src/log/coordinator.cpp ecf457ff266f447938ee6d2872a8ef3b6d50517e 
  src/log/log.cpp 0940f9288509409c1d593c27da48cfa2a50545c9 
  src/log/main.cpp 171c312562442836a2cf8f61f0a83615c18d0971 
  src/log/network.hpp 8750880e6cecb6edf4efab4f2b9afe3d8a4d5964 
  src/log/recover.hpp 97793b6e1a26f92b4ae20b82e7da18d063776ce6 
  src/log/recover.cpp eaf3fd334f7b66f9ba05f3856ee885bab9af62f6 
  src/log/tool/benchmark.cpp da35b08b5448c965cedd3d9349d06b4a99fabfce 
  src/master/registrar.cpp 4d1eaa04fcc7f3330bf3abab8533428848691f2c 
  src/slave/gc.hpp 9a09e7b3585217754a26597b77ea51e706ecb933 
  src/slave/gc.cpp a0af68b8d713a31bea533b24637861e81ca167e3 
  src/slave/state.cpp 91dee118d1e6866fb2b968765cfe7c6f1b5a3325 
  src/slave/status_update_manager.cpp 9c67b8526915cb529b5c5afd5b5e4a451bf94d61 
  src/tests/allocator.hpp c4d835afe180bcc2404cc3772af5f7c4885771bb 
  src/tests/containerizer.hpp ded331bc60078196abf9e1d338c23b9b962a3ad2 
  src/tests/containerizer.cpp 105ca9c0416b16fd26d396a4fdef7fbc8a43b8a4 
  src/tests/containerizer/composing_containerizer_tests.cpp e7e3b622b6606a812aef046c761bf92368d34af2

  src/tests/containerizer/docker_containerizer_tests.cpp 4e5b1fd1628504d346cced545f7911d6b6443773

  src/tests/containerizer/docker_tests.cpp 7b73a4939da33d0b7dd08fdcf56525b6403eada3 
  src/tests/containerizer/external_containerizer_test.cpp 226eac56725e908040abda306a2e5e3c96bce9d7

  src/tests/containerizer/isolator_tests.cpp 827c9f06b97191a5b74bb8fa2ef716c4282e7518 
  src/tests/containerizer/launcher.hpp 49f8ecb47abb098bf76017f79b7d00380401efe4 
  src/tests/containerizer/port_mapping_tests.cpp 94d6d7589a4d9accff6f43ad6abbf05bf3be7ee5

  src/tests/disk_quota_tests.cpp f379a6e351fbcf8b41d7db6ed62865ce55b0060e 
  src/tests/environment.cpp 6960c2a0165c4bb34851a0412c6b22b7da645540 
  src/tests/exception_tests.cpp a9b1c23d3e8460c5c67c8f399346f85f2ac8addf 
  src/tests/health_check_tests.cpp 47c35d15a259d470f21f81303879077787c125e7 
  src/tests/master_allocator_tests.cpp 32e3a4638273fa1c792c3c9425e0b2ff8f6bed03 
  src/tests/master_authorization_tests.cpp 16f1ab46a92137de01313a29dac2b18f18f5e816 
  src/tests/master_contender_detector_tests.cpp 2970986830d0cfaedbf17f3b002c40ac5c28bd2a 
  src/tests/master_slave_reconciliation_tests.cpp 03405e33d3f1cccbd5298810f5cd818c1dac8593

  src/tests/mesos.hpp 9174a3810d0da34b99dc257e9c77f83107fdd9f5 
  src/tests/reconciliation_tests.cpp 492560c430eba45e3a9f7a767ee761dfa0cacb05 
  src/tests/registrar_tests.cpp ba7c66ff83f09d68fb5324a3f85d2875068a35a6 
  src/tests/registrar_zookeeper_tests.cpp 98a5e312a8b2701dc8dc9b6593178bb52cd5e13c 
  src/tests/slave_recovery_tests.cpp af442cac40fb7b34e362dbfb2d864e7c8a010087 
  src/tests/state_tests.cpp 4ba42673eedfb4ab5633e2250a79bdde667eff95 
  src/tests/status_update_manager_tests.cpp f5313a124c59eba3da86a173817d0c2a6a943e17 
  src/tests/zookeeper.cpp d29b100b9d38f2c70160cbd59dfffdcbd1690f47 
  src/zookeeper/detector.cpp c9fa49c13028a81616b6fbf27c904e88c9bb0775 
  support/cpplint.py 5c5fd9945df7cbe4cae3e17ed30722905e5e5359 

Diff: https://reviews.apache.org/r/50887/diff/


Testing
-------

Pass `make` and `make tests`.


Thanks,

Gaojin CAO


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message