mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.
Date Mon, 08 Aug 2016 15:17:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50733/#review145106
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/isolator_tests.cpp (line 531)
<https://reviews.apache.org/r/50733/#comment211295>

    I would prefer to keep the original test name `ROOT_CGROUPS_RevocableCpu`.



src/tests/containerizer/isolator_tests.cpp (line 606)
<https://reviews.apache.org/r/50733/#comment211292>

    Ditto.



src/tests/containerizer/isolator_tests.cpp (line 724)
<https://reviews.apache.org/r/50733/#comment211293>

    Ditto



src/tests/containerizer/isolator_tests.cpp (line 816)
<https://reviews.apache.org/r/50733/#comment211294>

    Ditto


- Qian Zhang


On Aug. 4, 2016, 5:18 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50733/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2016, 5:18 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5973
>     https://issues.apache.org/jira/browse/MESOS-5973
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed CgroupsCpushareIsolatorProcess.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 1286ee08fe2d60867326a1f2585f054c20b52208 
>   src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
>   src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 
>   src/slave/containerizer/mesos/containerizer.cpp 86a8d8a85b6a33c87798108cb65af85bb9bbbc77

>   src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp 74982a610b6c0a74734165a0c6aa8c9f72f54deb

>   src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 221e814a448c4b5df9dab98de597451a24e2b89c

>   src/tests/containerizer/isolator_tests.cpp 488747347f71a6a1bb6bc01477143d077d4fd3eb

> 
> Diff: https://reviews.apache.org/r/50733/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message