mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 50812: Updated `HealthCheck` protobuf for HTTP and TCP health check.
Date Mon, 08 Aug 2016 10:33:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50812/#review145077
-----------------------------------------------------------


Fix it, then Ship it!




I'll address the outstanding issues and will commit shorty.


include/mesos/mesos.proto (lines 327 - 329)
<https://reviews.apache.org/r/50812/#comment211265>

    I can't befriend this syntax : ). I'd suggest we omit `*_CHECK` suffixes here and rename
the messages.



include/mesos/mesos.proto (line 336)
<https://reviews.apache.org/r/50812/#comment211266>

    To avoid naming collisiong, let's call it `HTTPCheckInfo`. We usually add `*Info` suffix
to proto messages to distinguish them from non-generated class names. Omitting "health" seems
reasonable if we are to introduce other check types, e.g. readiness checks.



include/mesos/mesos.proto (line 337)
<https://reviews.apache.org/r/50812/#comment211264>

    Let's mention we support either "http" or "https" now.



include/mesos/mesos.proto (line 347)
<https://reviews.apache.org/r/50812/#comment211270>

    We already mention this in the beginning.



include/mesos/mesos.proto (lines 354 - 355)
<https://reviews.apache.org/r/50812/#comment211272>

    How about:
    Consider adding a flag to enable task's certificate validation for HTTPS health checks,
see MESOS-5997.



include/mesos/mesos.proto (lines 361 - 362)
<https://reviews.apache.org/r/50812/#comment211269>

    "..., i.e. based on establishing a TCP connection to the specified port."
    
    for simplicity.



include/mesos/mesos.proto (line 364)
<https://reviews.apache.org/r/50812/#comment211267>

    `TCPCheckInfo`? See reasoning above.


- Alexander Rukletsov


On Aug. 5, 2016, 4:19 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50812/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2016, 4:19 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Mahler, and Gastón Kleiman.
> 
> 
> Bugs: MESOS-5987
>     https://issues.apache.org/jira/browse/MESOS-5987
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated `HealthCheck` protobuf for HTTP and TCP health check.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8c74d0bdc1d15074b55d1be84816307bb9478a38 
>   include/mesos/v1/mesos.proto 94b59dd75abfa9e8601e59f7a20dfd94bc88fa70 
> 
> Diff: https://reviews.apache.org/r/50812/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message