mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 50125: Added mesos-docker-executor support for device control.
Date Mon, 08 Aug 2016 06:35:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50125/#review145060
-----------------------------------------------------------




src/docker/executor.hpp (lines 78 - 79)
<https://reviews.apache.org/r/50125/#comment211229>

    what about rename it as `devices`?
    
    Ditto for the following.



src/docker/executor.cpp (line 163)
<https://reviews.apache.org/r/50125/#comment211231>

    s/vector<string> deviceList/const vector<string> deviceList



src/docker/executor.cpp (line 164)
<https://reviews.apache.org/r/50125/#comment211230>

    s/dev/device, we prefer a full name here for easy to understand.



src/docker/executor.cpp (lines 170 - 171)
<https://reviews.apache.org/r/50125/#comment211232>

    kill this, the `parse` already logged the message.


- Guangya Liu


On 八月 5, 2016, 9:52 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50125/
> -----------------------------------------------------------
> 
> (Updated 八月 5, 2016, 9:52 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a new flag '--device' to mesos-docker-executor, and gave its
> feature to control device exposition, isolation, and access permission.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 
>   src/docker/executor.cpp 445628c9164facdd8bd812c5b45e3b2b886ebf0e 
>   src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62 
> 
> Diff: https://reviews.apache.org/r/50125/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message