mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.
Date Mon, 08 Aug 2016 05:33:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50841/#review145056
-----------------------------------------------------------




src/slave/containerizer/docker.cpp (lines 1360 - 1428)
<https://reviews.apache.org/r/50841/#comment211216>

    What about putting those logic to a new function such as `DockerContainerizerProcess::_launchExecutorProcess`,
and here you can update the logic as:
    
    ```
    return allocator->allocate(requested)
      .then(defer(...))
    ```
    
    The `defer` will call the new added function `DockerContainerizerProcess::_launchExecutorProcess`,
using continuation here can make the main thread not blocked.



src/slave/containerizer/docker.cpp (line 1548)
<https://reviews.apache.org/r/50841/#comment211217>

    ```
    return allocator->deallocate(deallocated);
    ```



src/slave/containerizer/docker.cpp (line 1913)
<https://reviews.apache.org/r/50841/#comment211220>

    What about log a warning message here if failed to deallocate?
    
    ```
    allocator->deallocate(deallocated);
      .onFailed(defer(...) {
        LOG(WARNING) << "...";
      }));
    ```


- Guangya Liu


On 八月 5, 2016, 9:49 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50841/
> -----------------------------------------------------------
> 
> (Updated 八月 5, 2016, 9:49 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added control logic to allocate/deallocate GPUs to GPU-related task
> when the task is started/terminated.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.hpp 43ca4317d608b3b43dd7bd0d1b55c721e7364885 
>   src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62 
> 
> Diff: https://reviews.apache.org/r/50841/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message