mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 49854: Implemented `DevicesSubsystem`.
Date Sun, 07 Aug 2016 12:52:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49854/#review145041
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (lines 438 - 446)
<https://reviews.apache.org/r/49854/#comment211208>

    It seems we only need this `infos` map to check if the container has been prepared or
not, then I think we do not need this `infos` map and `Info` struct, a `hashset<ContainerID>
containIds` should be enough.



src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (line 64)
<https://reviews.apache.org/r/49854/#comment211199>

    In `MemorySubsystem`, I see you define `levels()` as its inline method which is originally
a static method in `mem.cpp`, but here I see you define `DEFAULT_WHITELIST_ENTRIES` as a static
variable just like what is originally done in `devices.cpp`.
    
    I think we need to be consistent: either both `levels()` and `DEFAULT_WHITELIST_ENTRIES`
are static in `subsystem.cpp` or both of them are defined in the related subsystem classes
(`MemorySubsystem` and `DevicesSubsystem`), I would prefer the former.


- Qian Zhang


On Aug. 4, 2016, 1:59 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49854/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2016, 1:59 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5651
>     https://issues.apache.org/jira/browse/MESOS-5651
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented `DevicesSubsystem`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 2659252d8cffcefc233bc85fb4707c8147272737

>   src/slave/containerizer/mesos/isolators/cgroups/constants.hpp c45d88092f3fe497373dfeaa8346aef9126c7b8b

>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 5f52a076a1fa3a21d886cb961ddeed5046a38d7c

>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp a30ecafcbecc9d3b6eeea2b04dcb4d278750af41

> 
> Diff: https://reviews.apache.org/r/49854/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message