mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 50411: Made the command executor use the unversioned protobufs internally.
Date Sat, 06 Aug 2016 00:34:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50411/#review145013
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On July 25, 2016, 9:36 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50411/
> -----------------------------------------------------------
> 
> (Updated July 25, 2016, 9:36 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently, the existing command executor was in the `v1` namespace
> and used the v1 protobufs. This change addresses that and moves the
> code to the `mesos::internal` namespace.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp 5a5f95f04a6ce096079b67397cb324575409f795 
>   src/launcher/posix/executor.hpp a508089461295749961058615cdd5ea38f561650 
>   src/launcher/posix/executor.cpp 6814b9f2333a9f040228c41e1d7101b93c760c01 
> 
> Diff: https://reviews.apache.org/r/50411/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message