mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 50410: Added helpers evolve/devolve functions for executor calls/events.
Date Sat, 06 Aug 2016 00:30:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50410/#review145012
-----------------------------------------------------------


Fix it, then Ship it!





src/internal/evolve.hpp (line 116)
<https://reviews.apache.org/r/50410/#comment211169>

    s/mesos::// to be consistent with above?


- Vinod Kone


On July 25, 2016, 9:36 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50410/
> -----------------------------------------------------------
> 
> (Updated July 25, 2016, 9:36 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5901
>     https://issues.apache.org/jira/browse/MESOS-5901
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds a couple of missing evolve/devolve helpers that
> we would be needing for making the existing command executor
> unversioned.
> 
> 
> Diffs
> -----
> 
>   src/internal/devolve.hpp 3812fd654d6cdceccf31b3f7c1a067cf2922e06f 
>   src/internal/devolve.cpp a2ad4641fcadef4003e487683fc0a73aeece7647 
>   src/internal/evolve.hpp 1e2d49b6a465c13dd055e54f0d4c49d22afc15c6 
>   src/internal/evolve.cpp 64818ccbbc4d0fcf6744e3f9a30c17c5332acccc 
> 
> Diff: https://reviews.apache.org/r/50410/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message