mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.
Date Sat, 06 Aug 2016 00:29:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50003/#review145011
-----------------------------------------------------------


Fix it, then Ship it!





src/local/local.cpp (lines 179 - 180)
<https://reviews.apache.org/r/50003/#comment211168>

    not sure if 'propagated_flags' is the right name.
    
    also, wondering if it would be intuitive to just do
    
    os::setenv("MESOS_WORK_DIR") = flags.work_dir;


- Vinod Kone


On July 21, 2016, 1:38 a.m., Ammar Askar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50003/
> -----------------------------------------------------------
> 
> (Updated July 21, 2016, 1:38 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Vinod Kone.
> 
> 
> Bugs: MESOS-5613
>     https://issues.apache.org/jira/browse/MESOS-5613
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Propagate work_dir flag from local runs to agents/masters.
> 
> 
> Diffs
> -----
> 
>   src/local/flags.hpp f0af0d2 
>   src/local/local.cpp a543aef 
> 
> Diff: https://reviews.apache.org/r/50003/diff/
> 
> 
> Testing
> -------
> 
> Manually tested that `mesos local` and `mesos-local` run now. Not sure if a regression
test for this would be good, please advise.
> 
> 
> Thanks,
> 
> Ammar Askar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message