mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Re: Review Request 50741: Replaced CHECK in SSL socket's `send()` with a log message.
Date Fri, 05 Aug 2016 22:19:11 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 5, 2016, 10:19 p.m.)

Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.

Bugs: MESOS-5986

Repository: mesos


The lambda placed on the event loop by the libevent SSL
socket's `send()` method previously used a `CHECK` to
ensure that the socket's `send_request` member was not
`nullptr`. This patch removes this check and replaces it
with a log message, since `send_request` may become
`nullptr` any time the socket receives an EOF or ERROR

Diffs (updated)

  3rdparty/libprocess/src/libevent_ssl_socket.cpp 97af3c25a350f4490f526e096678bb1eab066174



Ran a modified test case repeatedly to see this message printed when an SSL socket receives
an EOF at the appropriate time.


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message